summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph Helma <helma@in-silico.ch>2011-06-06 16:54:56 +0000
committerChristoph Helma <helma@in-silico.ch>2011-06-06 16:54:56 +0000
commit7bbc70d38d81a5a57d90c525d90ccf7bf8f59426 (patch)
tree34c43ef139456436b32ec42128c9162be8205d59
parentb542cfbd54901ad86d60fed03c8a05f9151f7616 (diff)
halts (partially) substituted by OpenTox errors
-rwxr-xr-xexample.rb2
-rwxr-xr-xlib/active_record_setup.rb4
-rwxr-xr-xreach_reports/reach_application.rb8
-rwxr-xr-xreach_reports/reach_service.rb2
-rwxr-xr-xreport/report_application.rb2
-rwxr-xr-xreport/report_persistance.rb2
6 files changed, 10 insertions, 10 deletions
diff --git a/example.rb b/example.rb
index b0b591e..636579e 100755
--- a/example.rb
+++ b/example.rb
@@ -80,7 +80,7 @@ class Example
task.progress(10)
log "upload dataset"
- halt 400,"File not found: "+@@file.path.to_s unless File.exist?(@@file.path)
+ raise OpenTox::BadRequestError.new"File not found: "+@@file.path.to_s unless File.exist?(@@file.path)
#data = File.read(@@file.path)
#data_uri = OpenTox::RestClientWrapper.post(CONFIG[:services]["opentox-dataset"],{:content_type => @@file_type},data).chomp("\n")
dataset = OpenTox::Dataset.create_from_csv_file(@@file.path,nil)
diff --git a/lib/active_record_setup.rb b/lib/active_record_setup.rb
index b43e692..5f081af 100755
--- a/lib/active_record_setup.rb
+++ b/lib/active_record_setup.rb
@@ -34,7 +34,7 @@ class ActiveRecord::Base
unless self.column_names.include?(key)
err = "no attribute found: '"+k.to_s+"'"
# if $sinatra
-# $sinatra.halt 400,err
+# $sinatra.raise OpenTox::BadRequestError.newerr
# else
raise err
# end
@@ -47,4 +47,4 @@ class ActiveRecord::Base
#puts "params after "+filter_params.inspect
self.find(:all, :conditions => filter_params)
end
-end \ No newline at end of file
+end
diff --git a/reach_reports/reach_application.rb b/reach_reports/reach_application.rb
index d914452..477adfb 100755
--- a/reach_reports/reach_application.rb
+++ b/reach_reports/reach_application.rb
@@ -25,7 +25,7 @@ require 'reach_reports/reach_service.rb'
require "lib/format_util.rb"
def extract_type(params)
- halt 400, "illegal type, neither QMRF nor QPRF: "+params[:type] unless params[:type] && params[:type] =~ /(?i)Q(M|P)RF/
+ raise OpenTox::BadRequestError.new "illegal type, neither QMRF nor QPRF: "+params[:type] unless params[:type] && params[:type] =~ /(?i)Q(M|P)RF/
params.delete("type")
end
@@ -96,7 +96,7 @@ get '/reach_report/:type/:id' do
case request.env['HTTP_ACCEPT'].to_s
when "application/rdf+xml"
- halt 400, "application/rdf+xml not yet supported"
+ raise OpenTox::BadRequestError.new "application/rdf+xml not yet supported"
owl = OpenTox::Owl.create(type+"Report",rep.report_uri)
owl.set_data( rep.get_content.keys_to_rdf_format )
owl.rdf
@@ -117,7 +117,7 @@ get '/reach_report/:type/:id' do
content_type "application/x-yaml"
rep.to_yaml
else
- halt 400, "MIME type '"+request.env['HTTP_ACCEPT'].to_s+"' not supported, valid Accept-Headers are \"application/rdf+xml\", \"application/x-yaml\", \"application/qmrf-xml\"."
+ raise OpenTox::BadRequestError.new "MIME type '"+request.env['HTTP_ACCEPT'].to_s+"' not supported, valid Accept-Headers are \"application/rdf+xml\", \"application/x-yaml\", \"application/qmrf-xml\"."
end
end
@@ -128,7 +128,7 @@ post '/reach_report/:type/:id' do
rep = ReachReports.get_report(type, params[:id])
input = request.env["rack.input"].read
- halt 400, "no xml data specified" unless input && input.to_s.size>0
+ raise OpenTox::BadRequestError.new "no xml data specified" unless input && input.to_s.size>0
LOGGER.debug "size of posted data: "+input.to_s.size.to_s
ReachReports::QmrfReport.from_xml(rep,input)
diff --git a/reach_reports/reach_service.rb b/reach_reports/reach_service.rb
index 916a7a4..c93385c 100755
--- a/reach_reports/reach_service.rb
+++ b/reach_reports/reach_service.rb
@@ -289,7 +289,7 @@ module ReachReports
#
# report_content = get_report(type, id).get_content
# keys.each do |k|
-# $sinatra.halt 400, type+" unknown report property '#{key}'" unless report_content.is_a?(Hash) and report_content.has_key?(k)
+# $sinatra.raise OpenTox::BadRequestError.new type+" unknown report property '#{key}'" unless report_content.is_a?(Hash) and report_content.has_key?(k)
# report_content = report_content[k]
# end
# report_content
diff --git a/report/report_application.rb b/report/report_application.rb
index 3c8670a..debfe07 100755
--- a/report/report_application.rb
+++ b/report/report_application.rb
@@ -7,7 +7,7 @@ end
def get_docbook_resource(filepath)
perform do |rs|
- halt 404,"not found: "+filepath unless File.exist?(filepath)
+ raise OpenTox::NotFoundError.new"not found: "+filepath unless File.exist?(filepath)
types = MIME::Types.type_for(filepath)
content_type(types[0].content_type) if types and types.size>0 and types[0]
result = body(File.new(filepath))
diff --git a/report/report_persistance.rb b/report/report_persistance.rb
index 78ae47b..e02387f 100755
--- a/report/report_persistance.rb
+++ b/report/report_persistance.rb
@@ -315,7 +315,7 @@ end
# unless prop_names.include?(key)
# err = "no attribute found: '"+k.to_s+"'"
# if $sinatra
-# $sinatra.halt 400,err
+# $sinatra.raise OpenTox::BadRequestError.newerr
# else
# raise err
# end