summaryrefslogtreecommitdiff
path: root/validation
diff options
context:
space:
mode:
authormguetlein <martin.guetlein@gmail.com>2011-05-27 10:09:35 +0200
committermguetlein <martin.guetlein@gmail.com>2011-05-27 10:09:35 +0200
commit654711ccecf3829f9ba8501fe67df06fd1aac9cf (patch)
tree9ec6babf6eb302bd379bcb5879a2b814dfce090f /validation
parent5abed3eedb5e0bc763574ef6a24b006546bdb22f (diff)
remove hack to determine prediction feature
Diffstat (limited to 'validation')
-rwxr-xr-xvalidation/validation_application.rb1
-rwxr-xr-xvalidation/validation_service.rb14
2 files changed, 4 insertions, 11 deletions
diff --git a/validation/validation_application.rb b/validation/validation_application.rb
index 32a1c99..39a5c50 100755
--- a/validation/validation_application.rb
+++ b/validation/validation_application.rb
@@ -4,7 +4,6 @@
end
require 'lib/dataset_cache.rb'
-require 'lib/feature_util.rb'
require 'validation/validation_service.rb'
get '/crossvalidation/?' do
diff --git a/validation/validation_service.rb b/validation/validation_service.rb
index a18c6ab..cc9faf5 100755
--- a/validation/validation_service.rb
+++ b/validation/validation_service.rb
@@ -46,13 +46,8 @@ module Validation
test_target_dataset_uris = vals.collect{|v| v.test_target_dataset_uri}
prediction_feature = vals.first.prediction_feature
prediction_dataset_uris = vals.collect{|v| v.prediction_dataset_uri}
- predicted_variables = []
- predicted_confidences = []
- models.size.times do |i|
- predicted = Lib::FeatureUtil.predicted_variables(models[i], prediction_dataset_uris[i], subjectid)
- predicted_variables << predicted[:predicted_variable]
- predicted_confidences << predicted[:predicted_confidence]
- end
+ predicted_variables = models.collect{|m| m.predicted_variable(subjectid)}
+ predicted_confidences = models.collect{|m| m.predicted_confidence(subjectid)}
prediction = Lib::OTPredictions.new( feature_type, test_dataset_uris, test_target_dataset_uris, prediction_feature,
prediction_dataset_uris, predicted_variables, predicted_confidences, subjectid )
@@ -224,9 +219,8 @@ module Validation
dependentVariables = model.metadata[OT.dependentVariables]
prediction_feature = self.prediction_feature ? nil : dependentVariables
algorithm_uri = self.algorithm_uri ? nil : model.metadata[OT.algorithm]
- predicted_variables = Lib::FeatureUtil.predicted_variables(model, prediction_dataset_uri, subjectid)
- predicted_variable = predicted_variables[:predicted_variable]
- predicted_confidence = predicted_variables[:predicted_confidence]
+ predicted_variable = model.predicted_variable(self.subjectid)
+ predicted_confidence = model.predicted_confidence(self.subjectid)
compute_validation_stats( model.feature_type(self.subjectid), predicted_variable, predicted_confidence,
prediction_feature, algorithm_uri, dry_run, task )
end